bartoszek/zephyr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

xtensa: gdbstub: update comments

Browse Source 
Update a comment about GDB use of register index and "regno"
parameters. Only some GDB versions use "idx" instead of "regno."

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
This commit is contained in:
Guennadi Liakhovetski 2025-06-04 10:26:20 +02:00 committed by Dan Kalowsky
parent b8d382ef09
commit b8a2eef2ef
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
arch/xtensa/core/gdbstub.c
View File

@ -717,8 +717,11 @@ size_t arch_gdb_reg_readone(struct gdb_ctx *ctx, uint8_t *buf, size_t buflen,
reg = &ctx->regs[idx];
/*
* GDB sends the G-packet index as register number
* instead of the actual Xtensa register number.
* Some GDB versions send the G-packet index as register number
* instead of the actual Xtensa register number. After checking
* 4 GDB versions one of them (Zephyr SDK for ESP32) sent the
* index while the others (Zephyr SDK for TGL and Cadence
* toolchain for TGL and MTL) sent register numbers.
*/
if (reg->idx == regno) {
if (reg->seqno != ctx->seqno) {
@ -769,9 +772,8 @@ size_t arch_gdb_reg_writeone(struct gdb_ctx *ctx, uint8_t *hex, size_t hexlen,
reg = &ctx->regs[idx];
/*
* Remember GDB sends index number instead of
* actual register number (as defined in Xtensa
* architecture).
* Remember some GDB versions send index number instead of
* actual register number (as defined in Xtensa architecture).
*/
if (reg->idx != regno) {
continue;