From b8a2eef2ef195a8f9c02957bb8a7ab4f6ad9188c Mon Sep 17 00:00:00 2001 From: Guennadi Liakhovetski Date: Wed, 4 Jun 2025 10:26:20 +0200 Subject: [PATCH] xtensa: gdbstub: update comments Update a comment about GDB use of register index and "regno" parameters. Only some GDB versions use "idx" instead of "regno." Signed-off-by: Guennadi Liakhovetski --- arch/xtensa/core/gdbstub.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/arch/xtensa/core/gdbstub.c b/arch/xtensa/core/gdbstub.c index fbbb01a204b..831a09c3178 100644 --- a/arch/xtensa/core/gdbstub.c +++ b/arch/xtensa/core/gdbstub.c @@ -717,8 +717,11 @@ size_t arch_gdb_reg_readone(struct gdb_ctx *ctx, uint8_t *buf, size_t buflen, reg = &ctx->regs[idx]; /* - * GDB sends the G-packet index as register number - * instead of the actual Xtensa register number. + * Some GDB versions send the G-packet index as register number + * instead of the actual Xtensa register number. After checking + * 4 GDB versions one of them (Zephyr SDK for ESP32) sent the + * index while the others (Zephyr SDK for TGL and Cadence + * toolchain for TGL and MTL) sent register numbers. */ if (reg->idx == regno) { if (reg->seqno != ctx->seqno) { @@ -769,9 +772,8 @@ size_t arch_gdb_reg_writeone(struct gdb_ctx *ctx, uint8_t *hex, size_t hexlen, reg = &ctx->regs[idx]; /* - * Remember GDB sends index number instead of - * actual register number (as defined in Xtensa - * architecture). + * Remember some GDB versions send index number instead of + * actual register number (as defined in Xtensa architecture). */ if (reg->idx != regno) { continue;