As of today <zephyr/zephyr.h> is 100% equivalent to <zephyr/kernel.h>. This patch proposes to then include <zephyr/kernel.h> instead of <zephyr/zephyr.h> since it is more clear that you are including the Kernel APIs and (probably) nothing else. <zephyr/zephyr.h> sounds like a catch-all header that may be confusing. Most applications need to include a bunch of other things to compile, e.g. driver headers or subsystem headers like BT, logging, etc. The idea of a catch-all header in Zephyr is probably not feasible anyway. Reason is that Zephyr is not a library, like it could be for example `libpython`. Zephyr provides many utilities nowadays: a kernel, drivers, subsystems, etc and things will likely grow. A catch-all header would be massive, difficult to keep up-to-date. It is also likely that an application will only build a small subset. Note that subsystem-level headers may use a catch-all approach to make things easier, though. NOTE: This patch is **NOT** removing the header, just removing its usage in-tree. I'd advocate for its deprecation (add a #warning on it), but I understand many people will have concerns. Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
45 lines
764 B
C
45 lines
764 B
C
/*
|
|
* Copyright (c) 2019 Intel Corporation
|
|
*
|
|
* SPDX-License-Identifier: Apache-2.0
|
|
*/
|
|
|
|
#include <zephyr/kernel.h>
|
|
#include <zephyr/device.h>
|
|
|
|
|
|
#define BAD_DRIVER_NAME "bad_driver"
|
|
|
|
typedef int (*bad_api_configure_t)(const struct device *dev,
|
|
uint32_t dev_config);
|
|
|
|
|
|
struct bad_driver_api {
|
|
bad_api_configure_t configure;
|
|
};
|
|
|
|
static int bad_configure(const struct device *dev, uint32_t config)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static const struct bad_driver_api funcs = {
|
|
.configure = bad_configure,
|
|
};
|
|
|
|
int bad_driver_init(const struct device *dev)
|
|
{
|
|
return -EINVAL;
|
|
}
|
|
|
|
/**
|
|
* @cond INTERNAL_HIDDEN
|
|
*/
|
|
DEVICE_DEFINE(bad_driver, BAD_DRIVER_NAME, &bad_driver_init,
|
|
NULL, NULL, NULL, POST_KERNEL,
|
|
CONFIG_KERNEL_INIT_PRIORITY_DEFAULT, &funcs);
|
|
|
|
/**
|
|
* @endcond
|
|
*/
|