The CI style checking solution can produce false positives when it's given code that it mis-parses, or that follows conventions it doesn't allow. Document a couple examples, and explicitly note that maintainers should override the -1 vote if they're encountered. For those following along in the commit history: static uint8_t __aligned(PAGE_SIZE) page_pool[PAGE_SIZE * POOL_PAGES]; checkpatch sees "uint8_t __aligned(PAGE_SIZE)" and infers a prototype for a function "__aligned" that takes an unnamed parameter of type "PAGE_SIZE". So it adds "PAGE_SIZE" as a known type name. IOPCTL_Type *base = config->base; This is common in driver code where the vendor HAL allows typedefs for structure types. checkpatch was designed for an environment with limited use of typedefs; "struct IPCTL_Type" would have been handled properly. Signed-off-by: Peter Bigot <peter.bigot@nordicsemi.no> |
||
|---|---|---|
| .. | ||
| api_lifecycle.png | ||
| api_lifecycle.rst | ||
| code_flow.rst | ||
| communication.rst | ||
| dev_env_and_tools.rst | ||
| documentation.rst | ||
| index.rst | ||
| issues.rst | ||
| lts.png | ||
| milestones2.jpg | ||
| milestones.jpg | ||
| proposals.rst | ||
| pull_request_classes.png | ||
| release_cycle.png | ||
| release_flow.png | ||
| release_process.rst | ||