zephyr/tests/subsys/settings/functional/fcb/settings_test_fcb.c
Gerard Marull-Paretas 79e6b0e0f6 includes: prefer <zephyr/kernel.h> over <zephyr/zephyr.h>
As of today <zephyr/zephyr.h> is 100% equivalent to <zephyr/kernel.h>.
This patch proposes to then include <zephyr/kernel.h> instead of
<zephyr/zephyr.h> since it is more clear that you are including the
Kernel APIs and (probably) nothing else. <zephyr/zephyr.h> sounds like a
catch-all header that may be confusing. Most applications need to
include a bunch of other things to compile, e.g. driver headers or
subsystem headers like BT, logging, etc.

The idea of a catch-all header in Zephyr is probably not feasible
anyway. Reason is that Zephyr is not a library, like it could be for
example `libpython`. Zephyr provides many utilities nowadays: a kernel,
drivers, subsystems, etc and things will likely grow. A catch-all header
would be massive, difficult to keep up-to-date. It is also likely that
an application will only build a small subset. Note that subsystem-level
headers may use a catch-all approach to make things easier, though.

NOTE: This patch is **NOT** removing the header, just removing its usage
in-tree. I'd advocate for its deprecation (add a #warning on it), but I
understand many people will have concerns.

Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
2022-09-05 16:31:47 +02:00

28 lines
727 B
C

/* SPDX-License-Identifier: Apache-2.0 */
/* Copyright (c) 2022 Nordic semiconductor ASA */
#include <zephyr/kernel.h>
#include <zephyr/ztest.h>
#include <errno.h>
#include <zephyr/settings/settings.h>
#include <zephyr/fs/fcb.h>
ZTEST(settings_functional, test_setting_storage_get)
{
int rc;
void *storage;
struct fcb_entry loc;
memset(&loc, 0, sizeof(struct fcb_entry));
rc = settings_storage_get(&storage);
zassert_equal(0, rc, "Can't fetch storage reference (err=%d)", rc);
zassert_not_null(storage, "Null reference.");
loc.fe_sector = NULL;
rc = fcb_getnext((struct fcb *)storage, &loc);
zassert_equal(rc, 0, "Can't read fcb (err=%d)", rc);
}
ZTEST_SUITE(settings_functional, NULL, NULL, NULL, NULL, NULL);