bartoszek/zephyr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mgmt: mcumgr: grp: shell_mgmt: Fix issue with unset variable

Browse Source 
Fixes an issue where a variable was used without being correctly
set by other parts of the code.

Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
This commit is contained in:
Jamie McCrae 2023-06-22 08:52:23 +01:00 committed by Carles Cufí
parent 0736448d37
commit fbacedaef8
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
subsys/mgmt/mcumgr/grp/shell_mgmt/src/shell_mgmt.c
View File

@ -83,9 +83,6 @@ shell_mgmt_exec(struct smp_streamer *ctxt)
ok = zcbor_tstr_decode(zsd, &value);
if (ok) {
/* TODO: This is original error when failed to collect command line
* to buffer, but should be rather MGMT_ERR_ENOMEM.
*/
if ((len + value.len) >= (ARRAY_SIZE(line) - 1)) {
ok = smp_add_cmd_ret(zse, MGMT_GROUP_ID_SHELL,
SHELL_MGMT_RET_RC_COMMAND_TOO_LONG);
@ -95,7 +92,7 @@ shell_mgmt_exec(struct smp_streamer *ctxt)
memcpy(&line[len], value.value, value.len);
len += value.len + 1;
line[len - 1] = ' ';
} else {
} else if (len > 0) {
line[len - 1] = 0;
/* Implicit break by while condition */
}