From fa92bfe3c1a615773aebd2e271a5ed17f3a2d24b Mon Sep 17 00:00:00 2001 From: Leandro Pereira Date: Mon, 23 Oct 2017 12:47:52 -0700 Subject: [PATCH] drivers: gpio: gecko: GPIO driver ignores pull-up/pull-down settings Fixes #4395. Coverity-ID: 178059 Signed-off-by: Leandro Pereira --- drivers/gpio/gpio_gecko.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio_gecko.c b/drivers/gpio/gpio_gecko.c index 0574c4dcc69..6a37011546e 100644 --- a/drivers/gpio/gpio_gecko.c +++ b/drivers/gpio/gpio_gecko.c @@ -92,16 +92,15 @@ static int gpio_gecko_configure(struct device *dev, } if ((flags & GPIO_DIR_MASK) == GPIO_DIR_IN) { - if ((flags & GPIO_PUD_MASK) == GPIO_PUD_PULL_UP) { mode = gpioModeInputPull; out = 1; /* pull-up*/ } else if ((flags & GPIO_PUD_MASK) == GPIO_PUD_PULL_DOWN) { mode = gpioModeInputPull; /* out = 0 means pull-down*/ + } else { + mode = gpioModeInput; } - - mode = gpioModeInput; } else { /* GPIO_DIR_OUT */ mode = gpioModePushPull; }