bartoszek/zephyr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

samples: net: zperf: Check pkt before accessing it

Browse Source 
The pkt was accessed before NULL check.

Coverity-CID: 179250
Fixes #5059

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
This commit is contained in:
Jukka Rissanen 2017-11-22 09:49:19 +02:00 committed by Anas Nashif
parent b0b053e91e
commit f7f671d18b
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
samples/net/zperf/src/zperf_udp_uploader.c
View File

@ -27,6 +27,11 @@ static inline void zperf_upload_decode_stat(struct net_pkt *pkt,
u16_t offset;
u16_t pos;
if (!pkt) {
printk(TAG "ERROR! Failed to receive statistic\n");
return;
}
frag = net_frag_get_pos(pkt,
net_pkt_ip_hdr_len(pkt) +
net_pkt_ipv6_ext_len(pkt) +
@ -39,10 +44,7 @@ static inline void zperf_upload_decode_stat(struct net_pkt *pkt,
}
/* Decode stat */
if (!pkt) {
printk(TAG "ERROR! Failed to receive statistic\n");
return;
} else if (net_pkt_appdatalen(pkt) <
if (net_pkt_appdatalen(pkt) <
(sizeof(struct zperf_server_hdr) +
sizeof(struct zperf_udp_datagram))) {
printk(TAG "ERROR! Statistics too small\n");