bartoszek/zephyr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

spinlock: validate: fix the dependency with MP_NUM_CPUS

Browse Source 
the implementation of spinlock validation uses two LSB bits in the
bottom of a pointer union to store a CPU index, which only has space
for 4 CPUS. the MP_NUM_CPUS should be <= 4.

Signed-off-by: Watson Zeng <zhiwei@synopsys.com>
This commit is contained in:
Watson Zeng 2021-01-12 15:27:55 +08:00 committed by Anas Nashif
parent 3d267eee15
commit f71cd2aaf5
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/spinlock.h
View File

@ -61,7 +61,7 @@ struct k_spinlock {
bool z_spin_lock_valid(struct k_spinlock *l);
bool z_spin_unlock_valid(struct k_spinlock *l);
void z_spin_lock_set_owner(struct k_spinlock *l);
BUILD_ASSERT(CONFIG_MP_NUM_CPUS < 4, "Too many CPUs for mask");
BUILD_ASSERT(CONFIG_MP_NUM_CPUS <= 4, "Too many CPUs for mask");
#endif /* CONFIG_SPIN_VALIDATE */
/**

2
subsys/debug/Kconfig
View File

@ -222,7 +222,7 @@ config ASSERT_LEVEL
config SPIN_VALIDATE
bool "Enable spinlock validation"
depends on ASSERT
depends on MP_NUM_CPUS < 4
depends on MP_NUM_CPUS <= 4
default y if !FLASH || FLASH_SIZE > 32
help
There's a spinlock validation framework available when asserts are

2
tests/kernel/spinlock/testcase.yaml
View File

@ -1,4 +1,4 @@
tests:
kernel.multiprocessing.spinlock:
tags: smp spinlock
filter: CONFIG_SMP and CONFIG_MP_NUM_CPUS > 1
filter: CONFIG_SMP and CONFIG_MP_NUM_CPUS > 1 and CONFIG_MP_NUM_CPUS <= 4