bartoszek/zephyr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

net: sockets: packet: Remove obsolete TODO

Browse Source 
It turns out that all of the items listed under TODO section for packet
socket implmeentation has been adressed over time, threfore remove the
obsolete TODO.

Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
This commit is contained in:
Robert Lubos 2022-05-12 14:09:36 +02:00 committed by Marti Bolivar
parent 3cd88c72b1
commit eddb6c8111
1 changed files with 0 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
subsys/net/ip/packet_socket.c
View File

@ -34,20 +34,6 @@ enum net_verdict net_packet_socket_input(struct net_pkt *pkt, uint8_t proto)
return NET_CONTINUE;
}
#endif
/* Currently we are skipping L2 layer verification and not
* removing L2 header from packet.
* TODO :
* 1) Pass it through L2 layer, so that L2 will verify
* that packet is intended to us or not and sets src and dst lladdr.
* And L2 should not pull off L2 header when combination of socket
* like this AF_PACKET, SOCK_RAW and ETH_P_ALL proto.
* 2) Socket combination of AF_INET, SOCK_RAW, IPPROTO_RAW
* packet has to go through L2 and L2 verifies it's header and removes
* header. Only packet with L3 header will be given to socket.
* 3) If user opens raw and non raw socket together, based on raw
* socket combination packet has to be feed to raw socket and only
* data part to be feed to non raw socket.
*/
orig_family = net_pkt_family(pkt);