From ea16d0e25d5cb327a0eceb2495141a2d53346543 Mon Sep 17 00:00:00 2001 From: Fabio Baltieri Date: Thu, 8 May 2025 17:44:04 +0100 Subject: [PATCH] Revert "ci: workflows: check for manifest dnm in the manifest workflow" This reverts commit 370e0882cbadf4f603f5d41834e34e9282546b64, the condition is evaluated at workout creation time so this does not work at all, plus some conditions don't have a label removal logic so pairing this with the manifest run does not work anyway. Signed-off-by: Fabio Baltieri --- .github/workflows/manifest.yml | 7 ------- .github/workflows/pr_metadata_check.yml | 1 + 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/.github/workflows/manifest.yml b/.github/workflows/manifest.yml index 563dd25f012..bacd0ba768b 100644 --- a/.github/workflows/manifest.yml +++ b/.github/workflows/manifest.yml @@ -53,10 +53,3 @@ jobs: verbosity-level: '1' labels: 'manifest' dnm-labels: 'DNM (manifest)' - - - name: Check for label - if: ${{ contains(github.event.*.labels.*.name, 'DNM (manifest)') }} - run: | - echo "Pull request is labeled as 'DNM (manifest)'." - echo "This workflow fails so that the pull request cannot be merged." - exit 1 diff --git a/.github/workflows/pr_metadata_check.yml b/.github/workflows/pr_metadata_check.yml index 199c76dde1b..3564c6352c8 100644 --- a/.github/workflows/pr_metadata_check.yml +++ b/.github/workflows/pr_metadata_check.yml @@ -20,6 +20,7 @@ jobs: steps: - name: Check for label if: ${{ contains(github.event.*.labels.*.name, 'DNM') || + contains(github.event.*.labels.*.name, 'DNM (manifest)') || contains(github.event.*.labels.*.name, 'TSC') || contains(github.event.*.labels.*.name, 'Architecture Review') || contains(github.event.*.labels.*.name, 'dev-review') }}