From e82e31e351d423e0f17df05ab2d38e049385cdeb Mon Sep 17 00:00:00 2001 From: Tomasz Bursztyka Date: Thu, 3 Jan 2019 12:03:21 +0100 Subject: [PATCH] net/icmpv4: A checksum value of 0 is valid Introduced by commit id de78a7af28. If the sum is 0xffff, a ~sum will give 0. Fixes #12164 Signed-off-by: Tomasz Bursztyka --- subsys/net/ip/icmpv4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/subsys/net/ip/icmpv4.c b/subsys/net/ip/icmpv4.c index 88183874a54..4a7a719a037 100644 --- a/subsys/net/ip/icmpv4.c +++ b/subsys/net/ip/icmpv4.c @@ -338,7 +338,7 @@ enum net_verdict net_icmpv4_input(struct net_pkt *pkt, bool bcast) return NET_DROP; } - if (!icmp_hdr.chksum || net_calc_chksum_icmpv4(pkt) != 0) { + if (net_calc_chksum_icmpv4(pkt) != 0) { NET_DBG("DROP: Invalid checksum"); goto drop; }