bartoszek/zephyr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ztest: native_sim: fail instead of crashing on wrong arguments

Browse Source 
Instead of crashing fail with a message when -test arguments is of
wrong format.

Fixes zephyrproject-rtos/zephyr#91655

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
This commit is contained in:
Anas Nashif 2025-06-17 13:38:24 -04:00 committed by Daniel DeGrasse
parent bec789d364
commit e31f9bf324
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
subsys/testsuite/ztest/src/ztest_posix.c
View File

@ -11,6 +11,7 @@
#include <zephyr/tc_util.h>
#include <zephyr/ztest_test.h>
#include "nsi_host_trampolines.h"
#include <nsi_tracing.h>
static const char *test_args;
static bool list_tests;
@ -161,10 +162,18 @@ static bool z_ztest_testargs_contains(const char *suite_name, const char *test_n
suite_arg = strtok_r(suite_test_pair, ":", &last_arg);
test_arg = strtok_r(NULL, ":", &last_arg);
/* Validate format: must be test_suite::* or test_suite::test_case */
if (!suite_arg || !test_arg || strtok_r(NULL, ":", &last_arg) != NULL) {
/* Invalid format, report error and exit */
nsi_print_error_and_exit(
"Invalid test argument format '%s'. Expected a set of pairs like"
"'suite::test' or 'suite::*', got instead '%s'.\n",
test_args, suite_test_pair);
}
found = !strcmp(suite_arg, suite_name);
if (test_name) {
found &= !strcmp(test_arg, "*") ||
!strcmp(test_arg, test_name);
found &= (!strcmp(test_arg, "*") || !strcmp(test_arg, test_name));
}
suite_test_pair = strtok_r(NULL, ",", &last_suite_test_pair);