From e2db76c9cc2edfb5564ebb2c70ac8f4649ca7e57 Mon Sep 17 00:00:00 2001 From: Tomasz Gorochowik Date: Wed, 16 May 2018 14:25:26 +0200 Subject: [PATCH] tests/net: Fix ethernet mgmt mac change test The test checked if the change was reported as successful and it always was. What needs to be done is comparing whether the mac address was actually changed to the requested one. This commit adds this check. Signed-off-by: Tomasz Gorochowik --- tests/net/ethernet_mgmt/src/main.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tests/net/ethernet_mgmt/src/main.c b/tests/net/ethernet_mgmt/src/main.c index 1939ece7c50..a3fc4beec14 100644 --- a/tests/net/ethernet_mgmt/src/main.c +++ b/tests/net/ethernet_mgmt/src/main.c @@ -163,6 +163,11 @@ static void test_change_mac_when_down(void) ret = net_mgmt(NET_REQUEST_ETHERNET_SET_MAC_ADDRESS, iface, ¶ms, sizeof(struct ethernet_req_params)); + zassert_equal(ret, 0, "unable to change mac address\n"); + + ret = memcmp(net_if_get_link_addr(iface)->addr, mac_addr_change, + sizeof(mac_addr_change)); + zassert_equal(ret, 0, "invalid mac address change\n"); net_if_up(iface);