bartoszek/zephyr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

samples: boards: Fix incorrect min max range validation

Browse Source 
Fixing the min max range validation where condtions on
upper and lower bound are logically 'ANDed'. Fixing it
by logical ORing the result.

CID: 18325, 18326
Fixes Issue #9289
Fixes Issue #9290

Signed-off-by: Subramanian Meenakshi Sundaram <subbu147@gmail.com>
This commit is contained in:
Subramanian Meenakshi Sundaram 2018-08-05 19:16:39 -07:00 committed by Anas Nashif
parent f24d4bb369
commit df20ebd64a
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
samples/boards/nrf52/mesh/onoff_level_lighting_vnd_app/src/mesh/device_composition.c
View File

@ -1335,12 +1335,12 @@ static void light_ctl_temp_range_set_unack(struct bt_mesh_model *model,
state->status_code = RANGE_SUCCESSFULLY_UPDATED;
/* This is as per 6.1.3.1 in Mesh Model Specification */
if (min < TEMP_MIN && min > TEMP_MAX) {
if (min < TEMP_MIN || min > TEMP_MAX) {
/* The provided value for Range Min cannot be set */
state->status_code = CANNOT_SET_RANGE_MIN;
}
if (max > TEMP_MAX && max < TEMP_MIN) {
if (max > TEMP_MAX || max < TEMP_MIN) {
/* The provided value for Range Max cannot be set */
state->status_code = CANNOT_SET_RANGE_MAX;
}