bartoszek/zephyr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ipc_service: ipc_icbmsg: fix unchecked error in icmsg_open()

Browse Source 
Coverity (CID 516253) reported that the return value of
initialize_tx_with_sid_disabled() was set but not used, leading to
potential silent failures.

Check if the return value is negative and propagate the error through the
existing cleanup path.

Fixes: CID 516253

Signed-off-by: Gaetan Perrot <gaetan.perrot@spacecubics.com>
This commit is contained in:
Gaetan Perrot 2025-06-27 01:08:02 +09:00 committed by Dan Kalowsky
parent e4e8870180
commit dd180c2789
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
subsys/ipc/ipc_service/lib/icmsg.c
View File

@ -436,6 +436,9 @@ int icmsg_open(const struct icmsg_config_t *conf,
MAKE_RX_HANDSHAKE(dev_data->local_sid, SID_DISCONNECTED));
} else if (UNBOUND_DISABLED) {
ret = initialize_tx_with_sid_disabled(dev_data);
if (ret < 0) {
goto cleanup_and_exit;
}
}
if (old_state == ICMSG_STATE_OFF && (UNBOUND_ENABLED || UNBOUND_DETECT)) {