From d9538ec6b3ef07d52859bc2d58433a5e4a0ca516 Mon Sep 17 00:00:00 2001 From: Leandro Pereira Date: Fri, 16 Feb 2018 17:20:32 -0800 Subject: [PATCH] drivers: system_apic: Correctly assert interrupt line number The interrupt line number is an unsigned integer; it makes no sense to compare if it is greater than or equal to 0. Coverity-CID: 182602 Signed-off-by: Leandro Pereira --- drivers/interrupt_controller/system_apic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/interrupt_controller/system_apic.c b/drivers/interrupt_controller/system_apic.c index a6eef85673a..54743fe3a87 100644 --- a/drivers/interrupt_controller/system_apic.c +++ b/drivers/interrupt_controller/system_apic.c @@ -47,7 +47,7 @@ void __irq_controller_irq_config(unsigned int vector, unsigned int irq, u32_t flags) { - __ASSERT(irq >= 0 && irq <= HARDWARE_IRQ_LIMIT, "invalid irq line"); + __ASSERT(irq <= HARDWARE_IRQ_LIMIT, "invalid irq line"); if (IS_IOAPIC_IRQ(irq)) { _ioapic_irq_set(irq, vector, flags);