bartoszek/zephyr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bluetooth: PACS: Fix duplicated entries in client list

Browse Source 
The client list is filled from the bonding table at registration
but this should only be done once like the callback registration

Signed-off-by: Yago Fontoura do Rosario <yafo@demant.com>
This commit is contained in:
Yago Fontoura do Rosario 2025-07-25 08:49:53 +02:00 committed by Fabio Baltieri
parent d9f82069b9
commit d3cc63ac71
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
subsys/bluetooth/audio/pacs.c
View File

@ -1324,7 +1324,7 @@ static void add_bonded_addr_to_client_list(const struct bt_bond_info *info, void
int bt_pacs_cap_register(enum bt_audio_dir dir, struct bt_pacs_cap *cap) int bt_pacs_cap_register(enum bt_audio_dir dir, struct bt_pacs_cap *cap)
{ {
const struct bt_audio_codec_cap *codec_cap; const struct bt_audio_codec_cap *codec_cap;
static bool callbacks_registered; static bool first_register;
sys_slist_t *pac; sys_slist_t *pac;
if (!cap || !cap->codec_cap) { if (!cap || !cap->codec_cap) {
@ -1338,18 +1338,18 @@ int bt_pacs_cap_register(enum bt_audio_dir dir, struct bt_pacs_cap *cap)
return -EINVAL; return -EINVAL;
} }
/* Restore bonding list */
bt_foreach_bond(BT_ID_DEFAULT, add_bonded_addr_to_client_list, NULL);
LOG_DBG("cap %p dir %s codec_cap id 0x%02x codec_cap cid 0x%04x codec_cap vid 0x%04x", cap, LOG_DBG("cap %p dir %s codec_cap id 0x%02x codec_cap cid 0x%04x codec_cap vid 0x%04x", cap,
bt_audio_dir_str(dir), codec_cap->id, codec_cap->cid, codec_cap->vid); bt_audio_dir_str(dir), codec_cap->id, codec_cap->cid, codec_cap->vid);
sys_slist_append(pac, &cap->_node); sys_slist_append(pac, &cap->_node);
if (!callbacks_registered) { if (!first_register) {
bt_conn_auth_info_cb_register(&auth_callbacks); bt_conn_auth_info_cb_register(&auth_callbacks);
callbacks_registered = true; /* Restore bonding list */
bt_foreach_bond(BT_ID_DEFAULT, add_bonded_addr_to_client_list, NULL);
first_register = true;
} }
if (IS_ENABLED(CONFIG_BT_PAC_SNK_NOTIFIABLE) && dir == BT_AUDIO_DIR_SINK) { if (IS_ENABLED(CONFIG_BT_PAC_SNK_NOTIFIABLE) && dir == BT_AUDIO_DIR_SINK) {