bartoszek/zephyr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

modem: cmux: Prevent NULL deref in dlci_open_handler

Browse Source 
Prevent unlikely item == NULL scenario (CID 323102) and remove
superflous cmux == NULL check (CID 334903)

Signed-off-by: Bjarki Arge Andreasen <bjarki@arge-andreasen.me>
This commit is contained in:
Bjarki Arge Andreasen 2024-02-15 07:03:00 +01:00 committed by Henrik Brix Andersen
parent 9633fb70a0
commit cc3076be1d
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
subsys/modem/modem_cmux.c
View File

@ -1015,13 +1015,16 @@ struct modem_pipe_api modem_cmux_dlci_pipe_api = {
static void modem_cmux_dlci_open_handler(struct k_work *item)
{
struct k_work_delayable *dwork = k_work_delayable_from_work(item);
struct modem_cmux_dlci *dlci = CONTAINER_OF(dwork, struct modem_cmux_dlci, open_work);
struct k_work_delayable *dwork;
struct modem_cmux_dlci *dlci;
if (dlci == NULL) {
if (item == NULL) {
return;
}
dwork = k_work_delayable_from_work(item);
dlci = CONTAINER_OF(dwork, struct modem_cmux_dlci, open_work);
dlci->state = MODEM_CMUX_DLCI_STATE_OPENING;
struct modem_cmux_frame frame = {