bartoszek/zephyr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bluetooth: TBS: Client: Fix sizeof('\0')

Browse Source 
sizeof('\0') is misleading as it will return 4 instead of 1,
since it will evaluate to sizeof(0), which returns the size
of the `int` type. Modify the expression to use sizeof(char)
with a comment.

Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
This commit is contained in:
Emil Gydesen 2025-03-27 23:13:37 +01:00 committed by Henrik Brix Andersen
parent 87d7fcf6c2
commit c6e7420d52
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
subsys/bluetooth/audio/tbs_client.c
View File

@ -852,7 +852,7 @@ static void tbs_client_discover_complete(struct bt_conn *conn, int err)
static bool can_add_string_to_net_buf(const struct net_buf_simple *buf, size_t len)
{
return buf->len + len + sizeof('\0') <= buf->size;
return buf->len + len + sizeof(char) /* NULL terminator size */ <= buf->size;
}
/**
@ -880,7 +880,8 @@ static int handle_string_long_read(struct bt_tbs_instance *inst, uint8_t err, co
* terminator
*/
LOG_DBG("Truncating string");
length = net_buf_simple_tailroom(&inst->net_buf) - sizeof('\0');
length = net_buf_simple_tailroom(&inst->net_buf) -
sizeof(char) /* NULL terminator size */;
net_buf_simple_add_mem(&inst->net_buf, data, length);
/* Ensure that the data is correctly truncated */