bartoszek/zephyr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drivers: usb_dc_it82xx2: fix uninitialized variable warning

Browse Source 
ep_ctrl and ep_trans_type is not used inside it82xx2_usb_dc_isr, this
triggers a compile warning. Move these variables to a smaller scope.

Signed-off-by: Ting Shen <phoenixshen@google.com>
This commit is contained in:
Ting Shen 2023-10-27 15:08:24 +08:00 committed by Carles Cufí
parent dfe1c3a32b
commit c5d3fc10c1
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/usb/device/usb_dc_it82xx2.c
View File

@ -719,7 +719,7 @@ static void it82xx2_ep_in_out_config(uint8_t idx)
}
}
static void it82xx2_usb_dc_trans_done(uint8_t ep_ctrl, uint8_t ep_trans_type)
static void it82xx2_usb_dc_trans_done(void)
{
struct usb_it82xx2_regs *const usb_regs =
(struct usb_it82xx2_regs *)it82xx2_get_usb_regs();
@ -730,12 +730,12 @@ static void it82xx2_usb_dc_trans_done(uint8_t ep_ctrl, uint8_t ep_trans_type)
int ret;
for (uint8_t idx = 0 ; idx < EP4 ; idx++) {
ep_ctrl = ep_regs[idx].ep_ctrl;
uint8_t ep_ctrl = ep_regs[idx].ep_ctrl;
/* check ready bit ,will be 0 when trans done */
if ((ep_ctrl & ENDPOINT_EN) && !(ep_ctrl & ENDPOINT_RDY)) {
if (idx == EP0) {
ep_trans_type = ep_regs[idx].ep_transtype_sts &
uint8_t ep_trans_type = ep_regs[idx].ep_transtype_sts &
DC_ALL_TRANS;
/* set up*/
@ -785,7 +785,6 @@ static void it82xx2_usb_dc_isr(void)
uint8_t status = usb_regs->dc_interrupt_status &
usb_regs->dc_interrupt_mask; /* mask non enable int */
uint8_t ep_ctrl, ep_trans_type;
/* reset */
if (status & DC_RESET_EVENT) {
@ -813,7 +812,7 @@ static void it82xx2_usb_dc_isr(void)
if (status & DC_TRANS_DONE) {
/* clear interrupt before new transaction */
usb_regs->dc_interrupt_status = DC_TRANS_DONE;
it82xx2_usb_dc_trans_done(ep_ctrl, ep_trans_type);
it82xx2_usb_dc_trans_done();
return;
}