From b0c28f2d00a293a1c18cfff8112edf2e96c9222a Mon Sep 17 00:00:00 2001 From: Baohong Liu Date: Thu, 8 Sep 2016 14:46:25 -0700 Subject: [PATCH] drivers: i2c: fix a compilation dependency issue Fix a compilation warning. Compilation of the i2c driver requires QMSI dma object file. As a solution, the current code has "selects DMA_QMSI" in i2c Kconfig. This results in a compilation warning since "select DMA" is also required. Adding "select DMA" and "select DMA_QMSI" together in i2c Kconfig can solve the compilation issue. But, this will cause the dma driver be unnecessarily enabled. So, the solution is to fix the issue in the QMSI part instead of in the shim driver. Jira: ZEP-777 ZEP-778 Change-Id: Id4c1f749bf71eece1e70583bd586a69b596768b2 Signed-off-by: Baohong Liu --- drivers/i2c/Kconfig | 1 - ext/hal/qmsi/Kbuild | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig index 1298816d089..d575840e32b 100644 --- a/drivers/i2c/Kconfig +++ b/drivers/i2c/Kconfig @@ -56,7 +56,6 @@ config I2C_QMSI_SS config I2C_QMSI bool "QMSI I2C driver" depends on I2C && QMSI - select DMA_QMSI default n help This option enable the QMSI I2C driver. diff --git a/ext/hal/qmsi/Kbuild b/ext/hal/qmsi/Kbuild index 4bb8336aae5..1330075c66d 100644 --- a/ext/hal/qmsi/Kbuild +++ b/ext/hal/qmsi/Kbuild @@ -14,7 +14,7 @@ obj-$(CONFIG_QMSI_BUILTIN) += soc/$(SOC_NAME)/drivers/rar.o endif obj-$(CONFIG_RTC_QMSI) += drivers/qm_rtc.o obj-$(CONFIG_WDT_QMSI) += drivers/qm_wdt.o -obj-$(CONFIG_I2C_QMSI) += drivers/qm_i2c.o +obj-$(CONFIG_I2C_QMSI) += drivers/qm_i2c.o drivers/qm_dma.o obj-$(CONFIG_PWM_QMSI) += drivers/qm_pwm.o obj-$(CONFIG_AIO_COMPARATOR_QMSI) += drivers/qm_comparator.o obj-$(CONFIG_AON_COUNTER_QMSI) += drivers/qm_aon_counters.o