From ae24329daaed6b00cfe650dea77f368bb738125c Mon Sep 17 00:00:00 2001 From: Anas Nashif Date: Thu, 17 Nov 2022 20:11:54 -0500 Subject: [PATCH] twister: show duplicates correctly Find duplicate test identifiers and report them with --list-test-duplicates. Signed-off-by: Anas Nashif --- scripts/pylib/twister/twisterlib/testplan.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/scripts/pylib/twister/twisterlib/testplan.py b/scripts/pylib/twister/twisterlib/testplan.py index 0910f980866..33c57395727 100755 --- a/scripts/pylib/twister/twisterlib/testplan.py +++ b/scripts/pylib/twister/twisterlib/testplan.py @@ -249,15 +249,16 @@ class TestPlan: return 1 def report_duplicates(self): - all_tests = self.get_all_tests() - - dupes = [item for item, count in collections.Counter(all_tests).items() if count > 1] + all_identifiers = [] + for _, ts in self.testsuites.items(): + all_identifiers.append(ts.id) + dupes = [item for item, count in collections.Counter(all_identifiers).items() if count > 1] if dupes: print("Tests with duplicate identifiers:") for dupe in dupes: print("- {}".format(dupe)) for dc in self.get_testsuite(dupe): - print(" - {}".format(dc)) + print(" - {}".format(dc.name)) else: print("No duplicates found.")