bartoszek/zephyr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gpio: Cleanup Atmel SAM3 gpio driver

Browse Source 
This patch addresses the following issues:
* Aligns the Kconfig code style with Zephyr projects requirements.
* Removes redundant "depends on" from Kconfig.
* Adds static to the gpio_sam3_init declaration.

Change-Id: If5c8a1822d6c116ea34d0f220f3e5fa359b6fa18
Signed-off-by: Vincenzo Frascino <vincenzo.frascino@linaro.org>
This commit is contained in:
Vincenzo Frascino 2016-11-14 17:15:07 +00:00 committed by Kumar Gala
parent da5dd09875
commit 9e7fec0ca4
2 changed files with 16 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
drivers/gpio/Kconfig.atmel_sam3
View File

@ -21,95 +21,91 @@ menuconfig GPIO_ATMEL_SAM3
depends on GPIO && SOC_ATMEL_SAM3
default n
help
Enable config options to support the PIO controllers
on Atmel SAM3 family processors.
Enable config options to support the PIO controllers
on Atmel SAM3 family processors.
Says n if not sure.
Says n if not sure.
if GPIO_ATMEL_SAM3
config GPIO_ATMEL_SAM3_PORTA
bool "Enable driver for Atmel SAM3 PIO Port A"
depends on GPIO_ATMEL_SAM3
default n
help
Build the driver to utilize PIO controller Port A.
Build the driver to utilize PIO controller Port A.
config GPIO_ATMEL_SAM3_PORTA_DEV_NAME
string "Device name for Port A"
depends on GPIO_ATMEL_SAM3_PORTA
default "PIOA"
help
Device name for Port A.
Device name for Port A.
config GPIO_ATMEL_SAM3_PORTA_IRQ_PRI
int "Interrupt Priority for Port A"
depends on GPIO_ATMEL_SAM3_PORTA
default 3
help
Interrupt priority for Port A.
Interrupt priority for Port A.
config GPIO_ATMEL_SAM3_PORTB
bool "Enable driver for Atmel SAM3 PIO Port B"
depends on GPIO_ATMEL_SAM3
default n
help
Build the driver to utilize PIO controller Port B.
Build the driver to utilize PIO controller Port B.
config GPIO_ATMEL_SAM3_PORTB_DEV_NAME
string "Device name for Port B"
depends on GPIO_ATMEL_SAM3_PORTB
default "PIOB"
help
Device name for Port B.
Device name for Port B.
config GPIO_ATMEL_SAM3_PORTB_IRQ_PRI
int "Interrupt Priority for Port B"
depends on GPIO_ATMEL_SAM3_PORTB
default 3
help
Interrupt priority for Port B.
Interrupt priority for Port B.
config GPIO_ATMEL_SAM3_PORTC
bool "Enable driver for Atmel SAM3 PIO Port C"
depends on GPIO_ATMEL_SAM3
default n
help
Build the driver to utilize PIO controller Port C.
Build the driver to utilize PIO controller Port C.
config GPIO_ATMEL_SAM3_PORTC_DEV_NAME
string "Device name for Port C"
depends on GPIO_ATMEL_SAM3_PORTC
default "PIOC"
help
Device name for Port C.
Device name for Port C.
config GPIO_ATMEL_SAM3_PORTC_IRQ_PRI
int "Interrupt Priority for Port C"
depends on GPIO_ATMEL_SAM3_PORTC
default 3
help
Interrupt priority for Port C.
Interrupt priority for Port C.
config GPIO_ATMEL_SAM3_PORTD
bool "Enable driver for Atmel SAM3 PIO Port D"
depends on GPIO_ATMEL_SAM3
default n
help
Build the driver to utilize PIO controller Port D.
Build the driver to utilize PIO controller Port D.
config GPIO_ATMEL_SAM3_PORTD_DEV_NAME
string "Device name for Port D"
depends on GPIO_ATMEL_SAM3_PORTD
default "PIOD"
help
Device name for Port D.
Device name for Port D.
config GPIO_ATMEL_SAM3_PORTD_IRQ_PRI
int "Interrupt Priority for Port D"
depends on GPIO_ATMEL_SAM3_PORTD
default 3
help
Interrupt priority for Port D.
Interrupt priority for Port D.
endif # GPIO_ATMEL_SAM3

2
drivers/gpio/gpio_atmel_sam3.c
View File

@ -284,7 +284,7 @@ static const struct gpio_driver_api gpio_sam3_drv_api_funcs = {
* @param dev Device struct
* @return 0 if successful, failed otherwise.
*/
int gpio_sam3_init(struct device *dev)
static int gpio_sam3_init(struct device *dev)
{
const struct gpio_sam3_config *cfg = dev->config->config_info;