bartoszek/zephyr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

net: shell: Fix array indexing with dynamic iface command

Browse Source 
Network interface numbering starts from 1, therefore when accessing
help/index array, the interface index should not be used directly, but
rather decremented by 1, to avoid out-of-bound access on those arrays.

Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
This commit is contained in:
Robert Lubos 2023-11-17 14:09:50 +01:00 committed by Carles Cufí
parent 237891973b
commit 8a75a4b9db
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
subsys/net/lib/shell/iface_dynamic.h
View File

@ -32,9 +32,9 @@ static char *set_iface_index_buffer(size_t idx)
return NULL;
}
snprintk(iface_index_buffer[idx], MAX_IFACE_STR_LEN, "%d", (uint8_t)idx);
snprintk(iface_index_buffer[idx - 1], MAX_IFACE_STR_LEN, "%d", (uint8_t)idx);
return iface_index_buffer[idx];
return iface_index_buffer[idx - 1];
}
static char *set_iface_index_help(size_t idx)
@ -56,14 +56,14 @@ static char *set_iface_index_help(size_t idx)
net_if_get_name(iface, name, CONFIG_NET_INTERFACE_NAME_LEN);
name[CONFIG_NET_INTERFACE_NAME_LEN] = '\0';
snprintk(iface_help_buffer[idx], MAX_IFACE_HELP_STR_LEN,
snprintk(iface_help_buffer[idx - 1], MAX_IFACE_HELP_STR_LEN,
"%s [%s] (%p)", name, iface2str(iface, NULL), iface);
#else
snprintk(iface_help_buffer[idx], MAX_IFACE_HELP_STR_LEN,
snprintk(iface_help_buffer[idx - 1], MAX_IFACE_HELP_STR_LEN,
"[%s] (%p)", iface2str(iface, NULL), iface);
#endif
return iface_help_buffer[idx];
return iface_help_buffer[idx - 1];
}
static void iface_index_get(size_t idx, struct shell_static_entry *entry)