From 837698b93583853bcbe56e251fecd99b96888130 Mon Sep 17 00:00:00 2001
From: Marc Herbert <marc.herbert@intel.com>
Date: Thu, 30 Nov 2023 23:55:26 +0000
Subject: [PATCH] cmake/compiler/: drop ERROR_QUIET when looking for compiler
 --version

Commit 40c2e08e8211 ("xcc/cmake: don't discard stderr; don't (ever!) use
ERROR_QUIET") fixed xcc but the corresponding code is duplicated. Fix
the duplicates too.

See that commit for the issue description, longer commit message and
rationale.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
---
 cmake/compiler/arcmwdt/generic.cmake  | 4 ++--
 cmake/compiler/armclang/generic.cmake | 4 ++--
 cmake/compiler/gcc/generic.cmake      | 6 +++---
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/cmake/compiler/arcmwdt/generic.cmake b/cmake/compiler/arcmwdt/generic.cmake
index c7ab586b3f3..d28ad81ea04 100644
--- a/cmake/compiler/arcmwdt/generic.cmake
+++ b/cmake/compiler/arcmwdt/generic.cmake
@@ -17,12 +17,12 @@ execute_process(
   COMMAND ${CMAKE_C_COMPILER} --version
   RESULT_VARIABLE ret
   OUTPUT_VARIABLE full_version_output
-  ERROR_QUIET
   )
 
 if(ret)
   message(FATAL_ERROR "Executing the below command failed. Are permissions set correctly?
-  '${CMAKE_C_COMPILER} --version'"
+  '${CMAKE_C_COMPILER} --version'
+  ${full_version_output}"
   )
 else()
   set(ARCMWDT_MIN_REQUIRED_VERS "2022.09")
diff --git a/cmake/compiler/armclang/generic.cmake b/cmake/compiler/armclang/generic.cmake
index 7804cd0e640..0f12abce247 100644
--- a/cmake/compiler/armclang/generic.cmake
+++ b/cmake/compiler/armclang/generic.cmake
@@ -28,13 +28,13 @@ endif()
 execute_process(
   COMMAND ${CMAKE_C_COMPILER} --version
   RESULT_VARIABLE ret
-  OUTPUT_QUIET
-  ERROR_QUIET
+  OUTPUT_VARIABLE stdoutput
   )
 
 if(ret)
   message(FATAL_ERROR "Executing the below command failed. "
   "Are permissions set correctly? '${CMAKE_C_COMPILER} --version' "
+  "${stdoutput}"
   "And is the license setup correctly ?"
   )
 endif()
diff --git a/cmake/compiler/gcc/generic.cmake b/cmake/compiler/gcc/generic.cmake
index ca96eb93809..c9cc643e3dd 100644
--- a/cmake/compiler/gcc/generic.cmake
+++ b/cmake/compiler/gcc/generic.cmake
@@ -18,12 +18,12 @@ endif()
 execute_process(
   COMMAND ${CMAKE_C_COMPILER} --version
   RESULT_VARIABLE ret
-  OUTPUT_QUIET
-  ERROR_QUIET
+  OUTPUT_VARIABLE stdoutput
   )
 if(ret)
   message(FATAL_ERROR "Executing the below command failed. Are permissions set correctly?
-'${CMAKE_C_COMPILER} --version'
+  ${CMAKE_C_COMPILER} --version
+  ${stdoutput}
 "
     )
 endif()