bartoszek/zephyr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ring_buffer: optimize the partial buffer loop

Browse Source 
It is more efficient to break early when size of claimed area becomes zero.

Signed-off-by: Nicolas Pitre <npitre@baylibre.com>
This commit is contained in:
Nicolas Pitre 2025-01-15 15:36:36 -05:00 committed by Benjamin Cabé
parent 67978f8ffc
commit 83279d1524
1 changed files with 20 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
lib/utils/ring_buffer.c
View File

@ -63,11 +63,14 @@ uint32_t ring_buf_put(struct ring_buf *buf, const uint8_t *data, uint32_t size)
do {
partial_size = ring_buf_put_claim(buf, &dst, size);
if (partial_size == 0) {
break;
}
memcpy(dst, data, partial_size);
total_size += partial_size;
size -= partial_size;
data += partial_size;
} while (size && partial_size);
} while (size != 0);
err = ring_buf_put_finish(buf, total_size);
__ASSERT_NO_MSG(err == 0);
@ -130,13 +133,16 @@ uint32_t ring_buf_get(struct ring_buf *buf, uint8_t *data, uint32_t size)
do {
partial_size = ring_buf_get_claim(buf, &src, size);
if (partial_size == 0) {
break;
}
if (data) {
memcpy(data, src, partial_size);
data += partial_size;
}
total_size += partial_size;
size -= partial_size;
} while (size && partial_size);
} while (size != 0);
err = ring_buf_get_finish(buf, total_size);
__ASSERT_NO_MSG(err == 0);
@ -154,12 +160,15 @@ uint32_t ring_buf_peek(struct ring_buf *buf, uint8_t *data, uint32_t size)
do {
partial_size = ring_buf_get_claim(buf, &src, size);
if (partial_size == 0) {
break;
}
__ASSERT_NO_MSG(data != NULL);
memcpy(data, src, partial_size);
data += partial_size;
total_size += partial_size;
size -= partial_size;
} while (size && partial_size);
} while (size != 0);
/* effectively unclaim total_size bytes */
err = ring_buf_get_finish(buf, 0);
@ -206,11 +215,14 @@ int ring_buf_item_put(struct ring_buf *buf, uint16_t type, uint8_t value,
do {
partial_size = ring_buf_put_claim(buf, &dst, size);
if (partial_size == 0) {
break;
}
memcpy(dst, data, partial_size);
size -= partial_size;
total_size += partial_size;
data += partial_size;
} while (size && partial_size);
} while (size != 0);
__ASSERT_NO_MSG(size == 0);
err = ring_buf_put_finish(buf, total_size);
@ -252,13 +264,16 @@ int ring_buf_item_get(struct ring_buf *buf, uint16_t *type, uint8_t *value,
do {
partial_size = ring_buf_get_claim(buf, &src, size);
if (partial_size == 0) {
break;
}
if (data) {
memcpy(data, src, partial_size);
data += partial_size;
}
total_size += partial_size;
size -= partial_size;
} while (size && partial_size);
} while (size != 0);
err = ring_buf_get_finish(buf, total_size);
__ASSERT_NO_MSG(err == 0);