bartoszek/zephyr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drivers: interrupt_controller: intc_plic: rewrite get_plic_dev_from_irq

Browse Source 
There's a ternary operator that depends on configuration-defined macro:
`CONFIG_DYNAMIC_INTERRUPTS` is not enabled by default
for any of the platforms that use PLIC,
it is possbile to set it to `=y` though.

This triggered the Coverity check to report it as dead code.

Fixes #65576.

Signed-off-by: Wojciech Sipak <wsipak@antmicro.com>
This commit is contained in:
Wojciech Sipak 2023-11-27 12:10:10 +01:00 committed by Carles Cufí
parent 78a819bb33
commit 76c8bf0f7c
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/interrupt_controller/intc_plic.c
View File

@ -116,10 +116,11 @@ static inline mem_addr_t get_threshold_priority_addr(const struct device *dev)
*/
static inline const struct device *get_plic_dev_from_irq(uint32_t irq)
{
const struct device *dev = COND_CODE_1(IS_ENABLED(CONFIG_DYNAMIC_INTERRUPTS),
(z_get_sw_isr_device_from_irq(irq)), (NULL));
return dev == NULL ? DEVICE_DT_INST_GET(0) : dev;
#ifdef CONFIG_DYNAMIC_INTERRUPTS
return z_get_sw_isr_device_from_irq(irq);
#else
return DEVICE_DT_INST_GET(0);
#endif
}
/**