bartoszek/zephyr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

lib: os: cast to the same size composite expression

Browse Source 
In file crc16_sw.c essential type of LHS operand (16 bit) is wider than
essential type of composite expression in RHS operand (8 bit).
In crc32c_sw.c and crc32_sw.c Essential type of LHS operand (32 bit) is
wider than essential type of composite expression in RHS operand (8 bit)

Found as a coding guideline violation (MISRA R10.7) by static
coding scanning tool.

Signed-off-by: Maksim Masalski <maksim.masalski@intel.com>
This commit is contained in:
Maksim Masalski 2021-06-10 15:50:18 +08:00 committed by Christopher Friedt
parent 57690f566e
commit 52a4ba26ce
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/os/crc16_sw.c
View File

@ -42,7 +42,7 @@ uint16_t crc16_ccitt(uint16_t seed, const uint8_t *src, size_t len)
e = seed ^ *src++;
f = e ^ (e << 4);
seed = (seed >> 8) ^ (f << 8) ^ (f << 3) ^ (f >> 4);
seed = (seed >> 8) ^ ((uint16_t)f << 8) ^ ((uint16_t)f << 3) ^ ((uint16_t)f >> 4);
}
return seed;

2
lib/os/crc32_sw.c
View File

@ -27,7 +27,7 @@ uint32_t crc32_ieee_update(uint32_t crc, const uint8_t *data, size_t len)
uint8_t byte = data[i];
crc = (crc >> 4) ^ table[(crc ^ byte) & 0x0f];
crc = (crc >> 4) ^ table[(crc ^ (byte >> 4)) & 0x0f];
crc = (crc >> 4) ^ table[(crc ^ ((uint32_t)byte >> 4)) & 0x0f];
}
return (~crc);

2
lib/os/crc32c_sw.c
View File

@ -33,7 +33,7 @@ uint32_t crc32_c(uint32_t crc, const uint8_t *data,
for (size_t i = 0; i < len; i++) {
crc = crc32c_table[(crc ^ data[i]) & 0x0F] ^ (crc >> 4);
crc = crc32c_table[(crc ^ (data[i] >> 4)) & 0x0F] ^ (crc >> 4);
crc = crc32c_table[(crc ^ ((uint32_t)data[i] >> 4)) & 0x0F] ^ (crc >> 4);
}
return last_pkt ? (crc ^ CRC32C_XOR_OUT) : crc;