From 31a4e1ccf4492cc1d8cf39d0e4dfb2e5d1f59588 Mon Sep 17 00:00:00 2001 From: Savinay Dharmappa Date: Wed, 21 Feb 2018 00:07:48 +0530 Subject: [PATCH] subsys: kernel_event_logger: change kernel event values Each bit of "_sys_k_event_logger_mask" corresponds to a kernel event type. Hence KERNEL_EVENT_TYPE values should be power of 2. Previous implementation was not adhering to it ,because of which "sys_k_must_log_event" and "sys_k_event_logger_set_mask" had unintended effects when used to mask certain kernel events. Signed-off-by: Savinay Dharmappa --- include/logging/kernel_event_logger.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/include/logging/kernel_event_logger.h b/include/logging/kernel_event_logger.h index 7d7908b509f..0b6520835d1 100644 --- a/include/logging/kernel_event_logger.h +++ b/include/logging/kernel_event_logger.h @@ -20,10 +20,10 @@ extern "C" { /* predefined event types */ -#define KERNEL_EVENT_LOGGER_CONTEXT_SWITCH_EVENT_ID 0x0001 -#define KERNEL_EVENT_LOGGER_INTERRUPT_EVENT_ID 0x0002 -#define KERNEL_EVENT_LOGGER_SLEEP_EVENT_ID 0x0003 -#define KERNEL_EVENT_LOGGER_THREAD_EVENT_ID 0x0004 +#define KERNEL_EVENT_LOGGER_CONTEXT_SWITCH_EVENT_ID BIT(0) +#define KERNEL_EVENT_LOGGER_INTERRUPT_EVENT_ID BIT(1) +#define KERNEL_EVENT_LOGGER_SLEEP_EVENT_ID BIT(2) +#define KERNEL_EVENT_LOGGER_THREAD_EVENT_ID BIT(3) #ifndef _ASMLANGUAGE @@ -174,7 +174,7 @@ static inline int sys_k_event_logger_get_mask(void) static inline int sys_k_must_log_event(int event_type) { #ifdef CONFIG_KERNEL_EVENT_LOGGER_DYNAMIC - return !!(_sys_k_event_logger_mask & (1 << (event_type - 1))); + return !!(_sys_k_event_logger_mask & event_type); #else ARG_UNUSED(event_type);