From 246e614ac340e2cc535b07fd67500a3de3e34a22 Mon Sep 17 00:00:00 2001 From: Daniel Kampert Date: Mon, 27 May 2024 13:39:49 +0200 Subject: [PATCH] drivers: rtc: rtc_mc146818: Patch incorrect field comparisons Minutes and hour values are incorrectly compared with MAX_SEC. Compare minutes and hour to MAX_MIN and MAX_HOUR respectively. Signed-off-by: Daniel Kampert --- drivers/rtc/rtc_mc146818.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc_mc146818.c b/drivers/rtc/rtc_mc146818.c index 15d36c623b0..66257cf8d74 100644 --- a/drivers/rtc/rtc_mc146818.c +++ b/drivers/rtc/rtc_mc146818.c @@ -377,13 +377,13 @@ static int rtc_mc146818_alarm_get_time(const struct device *dev, uint16_t id, ui } value = rtc_read(RTC_ALARM_MIN); - if (value <= MAX_SEC) { + if (value <= MAX_MIN) { timeptr->tm_min = value; (*mask) |= RTC_ALARM_TIME_MASK_MINUTE; } value = rtc_read(RTC_ALARM_HOUR); - if (value <= MAX_SEC) { + if (value <= MAX_HOUR) { timeptr->tm_hour = value; (*mask) |= RTC_ALARM_TIME_MASK_HOUR; }