From 209eb20056037d2d37ef2837d4fc4a7d8a30dc4f Mon Sep 17 00:00:00 2001 From: Marc Herbert Date: Tue, 21 Mar 2023 23:09:02 +0000 Subject: [PATCH] doc: modules: add link to new contributor expectations page Also mention that drafts reduce notification spam. Signed-off-by: Marc Herbert --- doc/develop/modules.rst | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/doc/develop/modules.rst b/doc/develop/modules.rst index 1f5b9737b31..a75f1f849e3 100644 --- a/doc/develop/modules.rst +++ b/doc/develop/modules.rst @@ -1031,7 +1031,9 @@ module. To avoid merging changes to master with pull request information, the pull request should be marked as ``DNM`` (Do Not Merge) or preferably a draft pull request to make sure it is not merged by mistake and to allow for the module to -be merged first and be assigned a permanent commit hash. Once the module is +be merged first and be assigned a permanent commit hash. Drafts reduce noise by +not automatically notifying anyone until marked as "Ready for review". +Once the module is merged, the revision will need to be changed either by the submitter or by the maintainer to the commit hash of the module which reflects the changes. @@ -1088,7 +1090,8 @@ Process for submitting changes to existing modules ================================================== #. Submit the changes using a pull request to an existing repository following - the :ref:`contribution guidelines `. + the :ref:`contribution guidelines ` and + :ref:`expectations `. #. Submit a pull request changing the entry referencing the module into the :zephyr_file:`west.yml` of the main Zephyr tree with the following information: