bartoszek/zephyr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

net: arp: Do not access NULL network packet

Browse Source 
The code was accessing network pkt before the value of the pkt
was checked.

Coverity-CID: 185394

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
This commit is contained in:
Jukka Rissanen 2018-04-28 15:19:06 +03:00
parent d9cdf7bf30
commit 2002a4e245
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
subsys/net/ip/l2/ethernet/arp.c
View File

@ -196,8 +196,8 @@ static inline struct net_pkt *prepare_arp(struct net_if *iface,
struct net_pkt *net_arp_prepare(struct net_pkt *pkt)
{
struct ethernet_context *ctx = net_if_l2_data(net_pkt_iface(pkt));
struct arp_entry *entry, *free_entry = NULL, *non_pending = NULL;
struct ethernet_context *ctx;
struct net_buf *frag;
struct net_linkaddr *ll;
struct net_eth_hdr *hdr;
@ -207,6 +207,8 @@ struct net_pkt *net_arp_prepare(struct net_pkt *pkt)
return NULL;
}
ctx = net_if_l2_data(net_pkt_iface(pkt));
if (net_pkt_ll_reserve(pkt) != sizeof(struct net_eth_hdr)
#if defined(CONFIG_NET_VLAN)
&& net_pkt_ll_reserve(pkt) != sizeof(struct net_eth_vlan_hdr)