From 133a299b50ed0f3e3d672238bb2dd0ac199045d2 Mon Sep 17 00:00:00 2001 From: Ulf Magnusson Date: Wed, 27 Jun 2018 12:43:06 +0200 Subject: [PATCH] drivers: i2c: Kconfig: Remove redundant 'default n' properties Bool symbols implicitly default to 'n'. A 'default n' can make sense e.g. in a Kconfig.defconfig file, if you want to override a 'default y' on the base definition of the symbol. It isn't used like that on any of these symbols though, and is inconsistent. This will make the auto-generated Kconfig documentation have "No defaults. Implicitly defaults to n." as well, which is clearer than 'default n if ...' Signed-off-by: Ulf Magnusson --- drivers/i2c/Kconfig | 13 ------------- drivers/i2c/Kconfig.dw | 2 -- drivers/i2c/Kconfig.esp32 | 5 ----- drivers/i2c/Kconfig.gpio | 5 ----- drivers/i2c/Kconfig.qmsi | 4 ---- drivers/i2c/Kconfig.sbcon | 5 ----- drivers/i2c/Kconfig.stm32 | 3 --- 7 files changed, 37 deletions(-) diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig index b9e9467dc4c..4aff5a8b5f5 100644 --- a/drivers/i2c/Kconfig +++ b/drivers/i2c/Kconfig @@ -11,7 +11,6 @@ # menuconfig I2C bool "I2C Drivers" - default n help Enable I2C Driver Configuration @@ -38,7 +37,6 @@ config SYS_LOG_I2C_LEVEL config I2C_0 bool "Enable I2C Port 0" - default n config I2C_0_NAME string "Port 0 device name" @@ -64,7 +62,6 @@ config I2C_0_IRQ_PRI config I2C_1 bool "Enable I2C Port 1" - default n config I2C_1_NAME string "Port 1 device name" @@ -90,7 +87,6 @@ config I2C_1_IRQ_PRI config I2C_2 bool "Enable I2C Port 2" - default n config I2C_2_NAME string "Port 2 device name" @@ -116,7 +112,6 @@ config I2C_2_IRQ_PRI config I2C_3 bool "Enable I2C Port 3" - default n config I2C_3_NAME string "Port 3 device name" @@ -142,7 +137,6 @@ config I2C_3_IRQ_PRI config I2C_4 bool "Enable I2C Port 4" - default n config I2C_4_NAME string "Port 4 device name" @@ -169,7 +163,6 @@ config I2C_4_IRQ_PRI config I2C_ATMEL_SAM3 bool "[deprecated] Atmel SAM3X I2C Driver" depends on SOC_SERIES_SAM3X - default n help This driver is deprecated and will be removed. Use "Atmel SAM (TWI) I2C driver" instead. @@ -182,7 +175,6 @@ config I2C_SAM_TWIHS bool "Atmel SAM (TWIHS) I2C driver" depends on SOC_FAMILY_SAM select HAS_DTS_I2C - default n help Enable Atmel SAM MCU Family (TWIHS) I2C bus driver. @@ -190,7 +182,6 @@ config I2C_SAM_TWI bool "Atmel SAM (TWI) I2C driver" depends on SOC_FAMILY_SAM select HAS_DTS_I2C - default n help Enable Atmel SAM MCU Family (TWI) I2C bus driver. @@ -198,7 +189,6 @@ config I2C_MCUX bool "MCUX I2C driver" depends on HAS_MCUX select HAS_DTS_I2C - default n help Enable the mcux I2C driver. @@ -206,20 +196,17 @@ config I2C_CC32XX bool "CC32XX I2C driver" depends on SOC_SERIES_CC32XX select HAS_DTS_I2C - default n help Enable the CC32XX I2C driver. config I2C_BITBANG bool - default n help Enable library used for software driven (bit banging) I2C support config I2C_NIOS2 bool "Nios-II I2C driver" depends on HAS_ALTERA_HAL - default n help Enable the Nios-II I2C driver. diff --git a/drivers/i2c/Kconfig.dw b/drivers/i2c/Kconfig.dw index be4f67609d9..04de17cb41e 100644 --- a/drivers/i2c/Kconfig.dw +++ b/drivers/i2c/Kconfig.dw @@ -6,7 +6,6 @@ menuconfig I2C_DW bool "Design Ware I2C support" - default n help Enable Design Ware I2C support on the selected board @@ -18,7 +17,6 @@ config I2C_DW_CLOCK_SPEED config I2C_DW_SHARED_IRQ bool - default n choice prompt "I2C_0 Interrupts via" diff --git a/drivers/i2c/Kconfig.esp32 b/drivers/i2c/Kconfig.esp32 index b41d8022c7d..7633d25c606 100644 --- a/drivers/i2c/Kconfig.esp32 +++ b/drivers/i2c/Kconfig.esp32 @@ -10,7 +10,6 @@ menuconfig I2C_ESP32 bool "ESP32 I2C" depends on I2C && SOC_ESP32 select GPIO_ESP32 - default n help Enables the ESP32 I2C driver @@ -28,11 +27,9 @@ config I2C_0_DEFAULT_CFG config I2C_ESP32_0_TX_LSB_FIRST bool "Port 0 Transmit LSB first" - default n config I2C_ESP32_0_RX_LSB_FIRST bool "Port 0 Receive LSB first" - default n config I2C_ESP32_0_IRQ int "Port 0 IRQ line" @@ -56,11 +53,9 @@ config I2C_1_DEFAULT_CFG config I2C_ESP32_1_TX_LSB_FIRST bool "Port 1 Transmit LSB first" - default n config I2C_ESP32_1_RX_LSB_FIRST bool "Port 1 Receive LSB first" - default n config I2C_ESP32_1_IRQ int "Port 1 IRQ line" diff --git a/drivers/i2c/Kconfig.gpio b/drivers/i2c/Kconfig.gpio index fd001f9f887..ebd3d5c3793 100644 --- a/drivers/i2c/Kconfig.gpio +++ b/drivers/i2c/Kconfig.gpio @@ -8,7 +8,6 @@ config I2C_GPIO bool "GPIO bit banging I2C support" depends on I2C select I2C_BITBANG - default n help Enable software driven (bit banging) I2C support using GPIO pins @@ -16,7 +15,6 @@ config I2C_GPIO config I2C_GPIO_0 bool "Enable GPIO Bit Bang I2C device 0" - default n depends on I2C_GPIO help This tells the driver to configure the I2C device at boot, depending @@ -52,7 +50,6 @@ config I2C_GPIO_0_SDA_PIN config I2C_GPIO_1 bool "Enable GPIO Bit Bang I2C device 1" - default n depends on I2C_GPIO help This tells the driver to configure the I2C device at boot, depending @@ -88,7 +85,6 @@ config I2C_GPIO_1_SDA_PIN config I2C_GPIO_2 bool "Enable GPIO Bit Bang I2C device 2" - default n depends on I2C_GPIO help This tells the driver to configure the I2C device at boot, depending @@ -124,7 +120,6 @@ config I2C_GPIO_2_SDA_PIN config I2C_GPIO_3 bool "Enable GPIO Bit Bang I2C device 3" - default n depends on I2C_GPIO help This tells the driver to configure the I2C device at boot, depending diff --git a/drivers/i2c/Kconfig.qmsi b/drivers/i2c/Kconfig.qmsi index e7fd96bdf4f..5f8d6ce2c38 100644 --- a/drivers/i2c/Kconfig.qmsi +++ b/drivers/i2c/Kconfig.qmsi @@ -7,7 +7,6 @@ menuconfig I2C_QMSI bool "QMSI I2C driver" depends on QMSI - default n help This option enable the QMSI I2C driver. @@ -40,7 +39,6 @@ endif # I2C_QMSI menuconfig I2C_QMSI_SS bool "QMSI I2C driver for the Sensor Subsystem" depends on QMSI - default n help This option enable the Sensor QMSI I2C driver. @@ -51,11 +49,9 @@ if I2C_QMSI_SS config I2C_SS_0 bool "Enable I2C_SS_0" - default n config I2C_SS_1 bool "Enable I2C SS Port 1" - default n config I2C_SS_SDA_HOLD int diff --git a/drivers/i2c/Kconfig.sbcon b/drivers/i2c/Kconfig.sbcon index ec7c4848b07..c0b9b5cd9dc 100644 --- a/drivers/i2c/Kconfig.sbcon +++ b/drivers/i2c/Kconfig.sbcon @@ -8,13 +8,11 @@ menuconfig I2C_SBCON bool "I2C driver for ARM's SBCon two-wire serial bus interface" depends on I2C && ARM select I2C_BITBANG - default n if I2C_SBCON config I2C_SBCON_0 bool "Enable SBCon device 0" - default n config I2C_SBCON_0_NAME depends on I2C_SBCON_0 @@ -23,7 +21,6 @@ config I2C_SBCON_0_NAME config I2C_SBCON_1 bool "Enable SBCon device 1" - default n config I2C_SBCON_1_NAME depends on I2C_SBCON_1 @@ -32,7 +29,6 @@ config I2C_SBCON_1_NAME config I2C_SBCON_2 bool "Enable SBCon device 2" - default n config I2C_SBCON_2_NAME depends on I2C_SBCON_2 @@ -41,7 +37,6 @@ config I2C_SBCON_2_NAME config I2C_SBCON_3 bool "Enable SBCon device 3" - default n config I2C_SBCON_3_NAME depends on I2C_SBCON_3 diff --git a/drivers/i2c/Kconfig.stm32 b/drivers/i2c/Kconfig.stm32 index e65a2a688e9..8821a7e3ed1 100644 --- a/drivers/i2c/Kconfig.stm32 +++ b/drivers/i2c/Kconfig.stm32 @@ -17,7 +17,6 @@ config I2C_STM32_V1 depends on SOC_SERIES_STM32F1X || SOC_SERIES_STM32F4X select HAS_DTS_I2C select USE_STM32_LL_I2C - default n help Enable I2C support on the STM32 F1 and F4X family of processors. This driver also supports the F2 and L1 series. @@ -28,7 +27,6 @@ config I2C_STM32_V2 select HAS_DTS_I2C select USE_STM32_LL_I2C select USE_STM32_LL_RCC if SOC_SERIES_STM32F0X || SOC_SERIES_STM32F3X - default n help Enable I2C support on the STM32 F0, F3 and L4X family of processors. This driver also supports the F7 and L0 series. @@ -36,7 +34,6 @@ config I2C_STM32_V2 config I2C_STM32_INTERRUPT bool "STM32 MCU I2C Interrupt Support" depends on I2C_STM32_V1 || I2C_STM32_V2 - default n help Enable Interrupt support for the I2C Driver