From 09ef2e667ff4de5d06080618cb7ffc7a64b44f44 Mon Sep 17 00:00:00 2001 From: Alexander Wachter Date: Tue, 2 Feb 2021 20:28:29 +0100 Subject: [PATCH] drivers: can: common: Fix uninitializes sjw Fix coverity CID 216784. SJW was not initialized in the tmp_res, but got copied to the result pointer, which overwrites the value. Signed-off-by: Alexander Wachter --- drivers/can/can_common.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/can/can_common.c b/drivers/can/can_common.c index 8712f6488b7..dc884a9e13b 100644 --- a/drivers/can/can_common.c +++ b/drivers/can/can_common.c @@ -216,7 +216,9 @@ static int can_calc_timing_int(uint32_t core_clock, struct can_timing *res, if (sp_err < sp_err_min) { sp_err_min = sp_err; - *res = tmp_res; + res->prop_seg = tmp_res.prop_seg; + res->phase_seg1 = tmp_res.phase_seg1; + res->phase_seg2 = tmp_res.phase_seg2; res->prescaler = (uint16_t)prescaler; if (sp_err == 0) { /* No better result than a perfect match*/