bartoszek/zephyr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drivers: uart: esp32: avoid pin re-configuration on uart_configure()

Browse Source 
Ensure uart_configure() only updates UART parameters without
reassigning pin configuration. Pin assignment via pinctrl is now
restricted to the initialization procedure, guaranteeing pins are
set only when properly configured.

Signed-off-by: Sylvio Alves <sylvio.alves@espressif.com>
This commit is contained in:
Sylvio Alves 2025-07-16 09:43:52 -03:00 committed by Anas Nashif
parent 5925d718ef
commit 05316bd0ed
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
drivers/serial/uart_esp32.c
View File

@ -273,12 +273,6 @@ static int uart_esp32_configure(const struct device *dev, const struct uart_conf
uint32_t sclk_freq;
uint32_t inv_mask = 0;
int ret = pinctrl_apply_state(config->pcfg, PINCTRL_STATE_DEFAULT);
if (ret < 0) {
return ret;
}
if (!device_is_ready(config->clock_dev)) {
return -ENODEV;
}
@ -939,17 +933,23 @@ unlock:
static int uart_esp32_init(const struct device *dev)
{
int ret;
struct uart_esp32_data *data = dev->data;
int ret = uart_esp32_configure(dev, &data->uart_config);
const struct uart_esp32_config *config = dev->config;
ret = pinctrl_apply_state(config->pcfg, PINCTRL_STATE_DEFAULT);
if (ret < 0) {
LOG_ERR("Error configuring UART pins (%d)", ret);
return ret;
}
ret = uart_esp32_configure(dev, &data->uart_config);
if (ret < 0) {
LOG_ERR("Error configuring UART (%d)", ret);
return ret;
}
#if CONFIG_UART_INTERRUPT_DRIVEN || CONFIG_UART_ASYNC_API
const struct uart_esp32_config *config = dev->config;
ret = esp_intr_alloc(config->irq_source,
ESP_PRIO_TO_FLAGS(config->irq_priority) |
ESP_INT_FLAGS_CHECK(config->irq_flags),